Skip to content

link with Clang static fuzzer lib if UMF_BUILD_FUZZTESTS is set #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025

Conversation

bratpiorka
Copy link
Contributor

@bratpiorka bratpiorka commented Apr 23, 2025

Link with the Clang static fuzzer library, libclang_rt.fuzzer_no_main-x86_64, if UMF_BUILD_FUZZTESTS is set.
Additionally, run extra tests in the nightly workflow that would fail without this change.

Successful run: https://github.com/oneapi-src/unified-memory-framework/actions/runs/14704118968/job/41260044056?pr=1284

-- Found fuzzer lib: /usr/lib/llvm-17/lib/clang/17/lib/linux/libclang_rt.fuzzer_no_main-x86_64.a
...
-- Fuzzing tests enabled.

Fixes: #590

@bratpiorka bratpiorka changed the title todo link with Clang static fuzzer lib if UMF_BUILD_FUZZTESTS is set Apr 23, 2025
@bratpiorka bratpiorka force-pushed the rrudnick_fuzz_fix branch 7 times, most recently from 661b67d to 9a038b3 Compare April 23, 2025 09:53
@bratpiorka bratpiorka marked this pull request as ready for review April 23, 2025 09:53
@bratpiorka bratpiorka requested a review from a team as a code owner April 23, 2025 09:53
@bratpiorka bratpiorka force-pushed the rrudnick_fuzz_fix branch 3 times, most recently from 0d8eccc to 97d5697 Compare April 23, 2025 11:27
@bratpiorka bratpiorka force-pushed the rrudnick_fuzz_fix branch 2 times, most recently from f869f69 to 2ed0ad0 Compare April 28, 2025 08:44
@bratpiorka bratpiorka requested a review from ldorau April 28, 2025 08:45
@bratpiorka bratpiorka force-pushed the rrudnick_fuzz_fix branch 2 times, most recently from a0478ae to a49dbdf Compare April 28, 2025 08:59
Copy link
Contributor

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test the Nightly build with the latest changes before merging.

@bratpiorka
Copy link
Contributor Author

Please test the Nightly build with the latest changes before merging.

the link to log from Nightly is in the description

@bratpiorka bratpiorka force-pushed the rrudnick_fuzz_fix branch 3 times, most recently from 0afa703 to aba3dae Compare April 29, 2025 08:25
@lukaszstolarczuk lukaszstolarczuk merged commit be747d0 into oneapi-src:main Apr 29, 2025
100 of 108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libumf.so.0: undefined symbol: __sancov_lowest_stack
3 participants